Additional query store improvements / fixes #6439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
hasAllRequiredParams
was iterating over indices instead of values —key in
should have beenkey of
enabled
edge case where if a store was persisted with anenabled
value different from itsenabled
config value, thesubscriptionManager
could possibly start out with a differentenabled
value than the store. Also fixes a similar issue affecting dynamic enabled params.cancel
from the args passed tofetcher
, as it was simply callingabort()
on theabortController
already provided tofetcher
. And for "hard" aborts to work (to abort the network call itself, not just the work that follows it), you need to pass theabortController
along to your actualfetch
request, so it was a bit of a misdirection.Screen recordings / screenshots
What to test